Detect phpcs version and add option --no-patch if version 2.*#16
Open
averagegeek wants to merge 1 commit intosoderlind:masterfrom
Open
Detect phpcs version and add option --no-patch if version 2.*#16averagegeek wants to merge 1 commit intosoderlind:masterfrom
averagegeek wants to merge 1 commit intosoderlind:masterfrom
Conversation
|
I encountered the same issue, but found out that by giving an options parameter with a cwd property solves the issue. Ie: |
Author
|
Yup, you're absolutely right and it's a better solution than checking for the version. Didn't knew you could pass in the working directory that way :) |
averagegeek
force-pushed
the
phpcs-2-no-patch
branch
from
0f31b73 to
aa3b715
Compare
the phpcbf command so reports can be generated properly and replacing the console.group() and console.groupEnd() with console.log() because those don't exists in node and trigger errors.
averagegeek
force-pushed
the
phpcs-2-no-patch
branch
from
aa3b715 to
ff53da4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into this issue, here is a proposition for a fix:
The extension does not work with phpcs 2.* on macos (haven't tried other operating systems) at the moment because by default, phpcs tries to write a .diff file in the current working directory. On macos, php is getting
/as working directory and obviously can't write the diff file and fail with an error. Passing in the working directory when calling the phpcbf command fixes the issue.Also the file argument is now added at the very end of the arguments and the
console.group()andconsole.groupEnd()calls were replaced as those methods don't exists in node and trigger errors.